Skip to content

Update fifo vendoring for typed errors#3545

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
estesp:update-fifo
Aug 16, 2019
Merged

Update fifo vendoring for typed errors#3545
crosbymichael merged 1 commit intocontainerd:masterfrom
estesp:update-fifo

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Aug 16, 2019

Update containerd/fifo vendor.

Signed-off-by: Phil Estes [email protected]

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 16, 2019

Required to properly complete #3536

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 16, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 16, 2019

Codecov Report

Merging #3545 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3545   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files         115      115           
  Lines       12790    12790           
=======================================
  Hits         5748     5748           
  Misses       6170     6170           
  Partials      872      872
Flag Coverage Δ
#linux 48.77% <ø> (ø) ⬆️
#windows 40.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666cfe1...80d31d1. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Comment thread vendor/github.com/containerd/fifo/errors.go Outdated
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 16, 2019

I will update this PR after we merge containerd/fifo#21

Update containerd/fifo vendor.

Signed-off-by: Phil Estes <[email protected]>
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 16, 2019

Fixed; PR updated

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 16, 2019

Build succeeded.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit c62b744 into containerd:master Aug 16, 2019
@estesp estesp deleted the update-fifo branch August 16, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants