Skip to content

AppVeyor: update to go 1.12.9#3541

Merged
estesp merged 1 commit intocontainerd:masterfrom
tao12345666333:bump-go-1.12.9
Aug 16, 2019
Merged

AppVeyor: update to go 1.12.9#3541
estesp merged 1 commit intocontainerd:masterfrom
tao12345666333:bump-go-1.12.9

Conversation

@tao12345666333
Copy link
Copy Markdown
Contributor

Signed-off-by: Jintao Zhang [email protected]

go1.12.9 (released 2019/08/15) includes fixes to the linker,
and the os and math/big packages.
See the Go
1.12.9 milestone
on our issue tracker for details.

Full diff golang/go@go1.12.8...go1.12.9

Going ahead and filing this. Follow #3531

Signed-off-by: Jintao Zhang <[email protected]>
@tao12345666333
Copy link
Copy Markdown
Contributor Author

tao12345666333 commented Aug 16, 2019

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 16, 2019

Codecov Report

Merging #3541 into master will decrease coverage by 3.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3541      +/-   ##
==========================================
- Coverage   48.77%   44.94%   -3.84%     
==========================================
  Files         104      115      +11     
  Lines       10215    12790    +2575     
==========================================
+ Hits         4982     5748     +766     
- Misses       4363     6170    +1807     
- Partials      870      872       +2
Flag Coverage Δ
#linux 48.77% <ø> (ø) ⬆️
#windows 40.18% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 47.9% <0%> (-8.6%) ⬇️
cio/io.go 46.47% <0%> (-8.53%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074b759...7682acb. Read the comment docs.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 16, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

prepared a backport for the 1.2.x release #3544

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e07359b into containerd:master Aug 16, 2019
@tao12345666333 tao12345666333 deleted the bump-go-1.12.9 branch August 17, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants