Ignore fifo error when using v2 multi-container shim#3536
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 19, 2019
Merged
Conversation
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3536 +/- ##
==========================================
- Coverage 44.94% 42.21% -2.73%
==========================================
Files 115 124 +9
Lines 12790 13692 +902
==========================================
+ Hits 5748 5780 +32
- Misses 6170 7039 +869
- Partials 872 873 +1
Continue to review full report at Codecov.
|
Member
|
LGTM |
fuweid
reviewed
Aug 15, 2019
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
bc690df to
751c1b6
Compare
|
Build succeeded.
|
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
751c1b6 to
ed75717
Compare
Contributor
Author
|
I'll do the rebase after #3545 has been merged |
|
Build succeeded.
|
Contributor
Author
|
seems that the CI of Windows is still not happy with fifo...working on it |
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
2 times, most recently
from
6ae8f26 to
f311ee6
Compare
|
Build succeeded.
|
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
2 times, most recently
from
6047504 to
0829e71
Compare
|
Build succeeded.
|
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
0829e71 to
ec76380
Compare
|
Build succeeded.
|
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
ec76380 to
754a911
Compare
Contributor
Author
Resolved by using separate check functions between unix and windows. I'm not sure it is ok to do this, but it seems that the |
|
Build succeeded.
|
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
754a911 to
ef29d86
Compare
|
Build succeeded.
|
estesp
changed the title
When using a multi-container shim, the fifo of the 2nd to Nth container will not be opened when the ctx is done. This will cause an `ErrReadClosed` that can be ignored. Signed-off-by: Li Yuxuan <[email protected]>
darfux
force-pushed
the
ignore_closed_fifo_error_under_multi_cntr
branch
from
ef29d86 to
04caf1f
Compare
|
Build succeeded.
|
Contributor
Author
|
@estesp thanks for correcting the title! I've corrected the commit title as well :) And it seems that all the CI would be happy now😃 |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a multi-container shim, the fifo of the 2nd to Nth container will not be opened when the ctx is done. This will cause a "closed fifo" error that can be ignored.
Signed-off-by: Li Yuxuan [email protected]