Skip to content

[release/1.2] Update cri to d928a4dd337fd2a992dbe72380eff2063c3ec62f.#3535

Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from
Random-Liu:update-cri-release-1.2
Aug 15, 2019
Merged

[release/1.2] Update cri to d928a4dd337fd2a992dbe72380eff2063c3ec62f.#3535
crosbymichael merged 1 commit intocontainerd:release/1.2from
Random-Liu:update-cri-release-1.2

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Aug 15, 2019 •
edited
Loading

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the 1.2.8 milestone Aug 15, 2019
@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Aug 15, 2019

/cc @estesp

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 15, 2019

Codecov Report

Merging #3535 into release/1.2 will decrease coverage by 3.58%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3535      +/-   ##
===============================================
- Coverage        47.25%   43.66%   -3.59%     
===============================================
  Files               92      101       +9     
  Lines             8471    10816    +2345     
===============================================
+ Hits              4003     4723     +720     
- Misses            3738     5357    +1619     
- Partials           730      736       +6
Flag Coverage Δ
#linux 47.25% <ø> (ø) ⬆️
#windows 40.78% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
remotes/docker/resolver.go 59.2% <0%> (-5.09%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70728b...941dd9f. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #3535 into release/1.2 will decrease coverage by 3.58%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3535      +/-   ##
===============================================
- Coverage        47.25%   43.66%   -3.59%     
===============================================
  Files               92      101       +9     
  Lines             8471    10816    +2345     
===============================================
+ Hits              4003     4723     +720     
- Misses            3738     5357    +1619     
- Partials           730      736       +6
Flag Coverage Δ
#linux 47.25% <ø> (ø) ⬆️
#windows 40.78% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
remotes/docker/resolver.go 59.2% <0%> (-5.09%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70728b...941dd9f. Read the comment docs.

estesp
estesp approved these changes Aug 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @Random-Liu!

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Aug 15, 2019

LGTM

@crosbymichael crosbymichael merged commit eed8acd into containerd:release/1.2 Aug 15, 2019
@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Aug 15, 2019

What about master? Should I update master to master of CRI?

@Random-Liu Random-Liu deleted the update-cri-release-1.2 branch August 15, 2019 17:14
@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Aug 15, 2019 •
edited
Loading

@crosbymichael We updated once of 1.3.0-beta.1 #3492

We can update before next release. :)

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 15, 2019

CRI: Updated libseccomp-golang to v0.9.1. NOTE: The minimum requirement of libseccomp is bumped to 2.3.0. (containerd/cri#1191)

see #3538 for consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@Random-Liu @codecov-io @crosbymichael @thaJeztah @estesp