Skip to content

Prepare v1.2.8 point release#3534

Merged
dmcgowan merged 1 commit intocontainerd:release/1.2from
estesp:prep-v1.2.8
Aug 22, 2019
Merged

Prepare v1.2.8 point release#3534
dmcgowan merged 1 commit intocontainerd:release/1.2from
estesp:prep-v1.2.8

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Aug 15, 2019

Add release notes and update version in preparation for v1.2.8 release
of containerd.

Preview of release notes: https://gist.github.com/estesp/d39a93bf47ed57ba2251265a4b718f25

Signed-off-by: Phil Estes [email protected]

@estesp estesp added this to the 1.2.8 milestone Aug 15, 2019
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 15, 2019

Verified travis CI is running Golang 1.12.8:

$ go version
go version go1.12.8 linux/amd64

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 15, 2019

@Random-Liu are there any CRI fixes that need to be vendored into release/1.2 before we cut a release? Anything to call out in release notes?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #3534 into release/1.2 will decrease coverage by 6.65%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.2   #3534      +/-   ##
==============================================
- Coverage        47.76%   41.1%   -6.66%     
==============================================
  Files               91      70      -21     
  Lines             8443    9480    +1037     
==============================================
- Hits              4033    3897     -136     
- Misses            3677    5019    +1342     
+ Partials           733     564     -169
Flag Coverage Δ
#linux ?
#windows 41.1% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 1.78% <0%> (-51.52%) ⬇️
archive/tar.go 16.99% <0%> (-33.86%) ⬇️
metadata/snapshot.go 21.53% <0%> (-33.23%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.69% <0%> (-6.51%) ⬇️
remotes/docker/resolver.go 59.2% <0%> (-5.09%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e060c4...a9ba2e6. Read the comment docs.

@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Aug 15, 2019

@estesp Yes. Let me do an update.

@estesp estesp force-pushed the prep-v1.2.8 branch 2 times, most recently from 6514b73 to 58e0a57 Compare August 15, 2019 14:06
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 15, 2019

Updated notes (https://gist.github.com/estesp/d39a93bf47ed57ba2251265a4b718f25) with CRI additions and rebased

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Aug 15, 2019

ping @estesp I also want to add this issue into release note. #3481 :)

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 15, 2019

Looks like we need to wait on Golang 1.12.9 (which is imminently being released it looks like) to have the os.RemoveAll without O_CLOEXEC fix for fd leakage. Others were also surprised it wasn't in 1.12.8, but apparently that only took the security fix, and other 1.12.x branch fixes will be in 1.12.9.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Aug 15, 2019

@estesp yeah. it is painful...

thaJeztah
thaJeztah reviewed Aug 16, 2019
View reviewed changes
Comment thread releases/v1.2.8.toml Outdated
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was (for now) reverted in #3538

thaJeztah
thaJeztah reviewed Aug 16, 2019
View reviewed changes
Comment thread releases/v1.2.8.toml Outdated
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up for Go 1.12.9; #3544

(Relates to #3481, golang/go#33405)

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 16, 2019

Updated to

  • remove mention of libseccomp (change reverted)
  • expand Golang runtime change description to separate 1.12.8 security patches from 1.12.9 bug fix (and added @fuweid requested note of the related issue from @Ace-Tang.
  • clarify opening overview to mention http2 not gRPC for the Golang CVEs

TravisCI is now using 1.12.9 (verified in recent PR run); AppVeyor PR #3544 needs to merge to finalize that across Windows + Linux.

Random-Liu
Random-Liu reviewed Aug 19, 2019
View reviewed changes
Comment thread releases/v1.2.8.toml Outdated
@AkihiroSuda AkihiroSuda mentioned this pull request Aug 20, 2019
Closed
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 21, 2019

Updated release notes with general info about CRI having fixes, and pointing to detailed list in next section. Added notes on last few backports (shim hang, and image & process env "merging"), and removed incorrect note on CRI + libseccomp changes, as those were reverted.

@estesp
Prepare v1.2.8 point release
a9ba2e6 
Add release notes and update version in preparation for v1.2.8 release
of containerd.

Signed-off-by: Phil Estes <[email protected]>
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 21, 2019

Updated generated release notes gist: https://gist.github.com/estesp/d39a93bf47ed57ba2251265a4b718f25

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Aug 21, 2019

Release Note LGTM 👍 @estesp Thanks!

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Aug 22, 2019

@containerd/containerd-maintainers @containerd/containerd-reviewers I believe we are ready to cut the 1.2.8 release; would be good to have some more eyes to make sure the notes captured everything.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Aug 22, 2019

LGTM

2 similar comments
@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Aug 22, 2019

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Aug 22, 2019

LGTM

@dmcgowan dmcgowan merged commit a4bc1d4 into containerd:release/1.2 Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@Random-Liu Random-Liu Random-Liu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.8

Development

Successfully merging this pull request may close these issues.

7 participants

@estesp @codecov-io @Random-Liu @fuweid @crosbymichael @dmcgowan @thaJeztah