Skip to content

[release/1.2 backport] update to go 1.12.8 (CVE-2019-9512, CVE-2019-9514)#3532

Merged
crosbymichael merged 6 commits intocontainerd:release/1.2from
thaJeztah:1.2_backport_bump_golang_1.12.8
Aug 14, 2019
Merged

[release/1.2 backport] update to go 1.12.8 (CVE-2019-9512, CVE-2019-9514)#3532
crosbymichael merged 6 commits intocontainerd:release/1.2from
thaJeztah:1.2_backport_bump_golang_1.12.8

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backports of:

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit ba9e1ea)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit a07e12c)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit a84f87d)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 2741dbe)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use the latest Go release for testing on AppVeyor

> go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler,
> and the linker. See the Go 1.12.7 milestone on our issue tracker for details:
>
> https://github.com/golang/go/issues?q=milestone%3AGo1.12.7

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 2ff7183)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
go1.12.8 (released 2019/08/13) includes security fixes to the net/http and net/url packages.
See the Go 1.12.8 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.8

- net/http: Denial of Service vulnerabilities in the HTTP/2 implementation
  net/http and golang.org/x/net/http2 servers that accept direct connections from untrusted
  clients could be remotely made to allocate an unlimited amount of memory, until the program
  crashes. Servers will now close connections if the send queue accumulates too many control
  messages.
  The issues are CVE-2019-9512 and CVE-2019-9514, and Go issue golang.org/issue/33606.
  Thanks to Jonathan Looney from Netflix for discovering and reporting these issues.
  This is also fixed in version v0.0.0-20190813141303-74dc4d7220e7 of golang.org/x/net/http2.
  net/url: parsing validation issue
- url.Parse would accept URLs with malformed hosts, such that the Host field could have arbitrary
  suffixes that would appear in neither Hostname() nor Port(), allowing authorization bypasses
  in certain applications. Note that URLs with invalid, not numeric ports will now return an error
  from url.Parse.
  The issue is CVE-2019-14809 and Go issue golang.org/issue/29098.
  Thanks to Julian Hector and Nikolai Krein from Cure53, and Adi Cohen (adico.me) for discovering
  and reporting this issue.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 1b389b3)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3532 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #3532   +/-   ##
============================================
  Coverage        43.66%   43.66%           
============================================
  Files              101      101           
  Lines            10816    10816           
============================================
  Hits              4723     4723           
  Misses            5357     5357           
  Partials           736      736
Flag Coverage Δ
#linux 47.25% <ø> (ø) ⬆️
#windows 40.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8ca75...4097217. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit e70728b into containerd:release/1.2 Aug 14, 2019
@thaJeztah thaJeztah deleted the 1.2_backport_bump_golang_1.12.8 branch August 14, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants