[release/1.2 backport] update to go 1.12.8 (CVE-2019-9512, CVE-2019-9514)#3532
Merged
crosbymichael merged 6 commits intocontainerd:release/1.2from Aug 14, 2019
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit ba9e1ea) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit a07e12c) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit a84f87d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 2741dbe) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use the latest Go release for testing on AppVeyor > go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler, > and the linker. See the Go 1.12.7 milestone on our issue tracker for details: > > https://github.com/golang/go/issues?q=milestone%3AGo1.12.7 Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 2ff7183) Signed-off-by: Sebastiaan van Stijn <[email protected]>
go1.12.8 (released 2019/08/13) includes security fixes to the net/http and net/url packages. See the Go 1.12.8 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.12.8 - net/http: Denial of Service vulnerabilities in the HTTP/2 implementation net/http and golang.org/x/net/http2 servers that accept direct connections from untrusted clients could be remotely made to allocate an unlimited amount of memory, until the program crashes. Servers will now close connections if the send queue accumulates too many control messages. The issues are CVE-2019-9512 and CVE-2019-9514, and Go issue golang.org/issue/33606. Thanks to Jonathan Looney from Netflix for discovering and reporting these issues. This is also fixed in version v0.0.0-20190813141303-74dc4d7220e7 of golang.org/x/net/http2. net/url: parsing validation issue - url.Parse would accept URLs with malformed hosts, such that the Host field could have arbitrary suffixes that would appear in neither Hostname() nor Port(), allowing authorization bypasses in certain applications. Note that URLs with invalid, not numeric ports will now return an error from url.Parse. The issue is CVE-2019-14809 and Go issue golang.org/issue/29098. Thanks to Julian Hector and Nikolai Krein from Cure53, and Adi Cohen (adico.me) for discovering and reporting this issue. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 1b389b3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
Aug 14, 2019
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3532 +/- ##
============================================
Coverage 43.66% 43.66%
============================================
Files 101 101
Lines 10816 10816
============================================
Hits 4723 4723
Misses 5357 5357
Partials 736 736
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports of: