Skip to content

[release/1.2] cherry-pick: Move ctr run --isolation to Windows only#3527

Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from
estesp:cp-2828-isolated
Aug 12, 2019
Merged

[release/1.2] cherry-pick: Move ctr run --isolation to Windows only#3527
crosbymichael merged 1 commit intocontainerd:release/1.2from
estesp:cp-2828-isolated

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Aug 12, 2019

Cherry-pick #2828 since it is effectively a bug-fix as there is no use of the flag on non-Windows.

Signed-off-by: Justin Terry (VM) [email protected]

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3527 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #3527   +/-   ##
============================================
  Coverage        43.66%   43.66%           
============================================
  Files              101      101           
  Lines            10816    10816           
============================================
  Hits              4723     4723           
  Misses            5357     5357           
  Partials           736      736
Flag Coverage Δ
#linux 47.25% <ø> (ø) ⬆️
#windows 40.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ba29c...11a25c8. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 3d8ca75 into containerd:release/1.2 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants