Skip to content

Add image usage function to client#3520

Merged
estesp merged 2 commits intocontainerd:masterfrom
dmcgowan:image-usage
Aug 12, 2019
Merged

Add image usage function to client#3520
estesp merged 2 commits intocontainerd:masterfrom
dmcgowan:image-usage

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Aug 9, 2019

The image usage function allows more configurable and accurate calculations of the resources held by an image.

The usage function allows more configurable and accurate calculations
of the usage for an image.

Signed-off-by: Derek McGowan <[email protected]>
Prevent an errgroup error from causing the acquire to
return a cancellation error. Previously any error
from the errgroup would cause the Dispatch to always
return the cancelled error.

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 9, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 9, 2019

Codecov Report

Merging #3520 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3520   +/-   ##
=======================================
  Coverage   44.27%   44.27%           
=======================================
  Files         124      124           
  Lines       13682    13682           
=======================================
  Hits         6058     6058           
  Misses       6688     6688           
  Partials      936      936
Flag Coverage Δ
#linux 48.05% <ø> (ø) ⬆️
#windows 39.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea13c9f...c017e0e. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ec0c968 into containerd:master Aug 12, 2019
@dmcgowan dmcgowan deleted the image-usage branch September 10, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants