Skip to content

Remove encryption code from containerd core#3516

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:remote-enc
Aug 13, 2019
Merged

Remove encryption code from containerd core#3516
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:remote-enc

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

We are separating out the encryption code and have designed a few new
interfaces and APIs for processing content streams. This keep the core
clean of encryption code but enables not only encryption but support of
multiple content types ( custom media types ).

Signed-off-by: Michael Crosby [email protected]

We are separating out the encryption code and have designed a few new
interfaces and APIs for processing content streams.  This keep the core
clean of encryption code but enables not only encryption but support of
multiple content types ( custom media types ).

Signed-off-by: Michael Crosby <[email protected]>
@crosbymichael crosbymichael added this to the 1.3 milestone Aug 9, 2019
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 9, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3516 into master will decrease coverage by 3.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3516      +/-   ##
==========================================
- Coverage   48.05%   44.94%   -3.12%     
==========================================
  Files         113      115       +2     
  Lines       10935    12790    +1855     
==========================================
+ Hits         5255     5748     +493     
- Misses       4746     6170    +1424     
+ Partials      934      872      -62
Flag Coverage Δ
#linux 48.77% <ø> (+0.71%) ⬆️
#windows 40.18% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 47.9% <0%> (-8.6%) ⬇️
cio/io.go 46.47% <0%> (-8.53%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06e605...d085d9b. Read the comment docs.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehazlett
Copy link
Copy Markdown
Member

LGTM

@estesp estesp merged commit b77e25d into containerd:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants