[release/1.2] cherry-pick: Limit multiple platform manifests to one for size check#3512
Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from Aug 9, 2019
Merged
Conversation
client.Pull will only pull one matching platform by default. When checking the size of image we match that behavior so that we don't look for multiple platforms that might not exist on disk. Signed-off-by: Darren Shepherd <[email protected]> (cherry picked from commit 1161409) Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3512 +/- ##
===============================================
- Coverage 47.25% 43.66% -3.59%
===============================================
Files 92 101 +9
Lines 8471 10816 +2345
===============================================
+ Hits 4003 4723 +720
- Misses 3738 5357 +1619
- Partials 730 736 +6
Continue to review full report at Codecov.
|
estesp
changed the title
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.Pull will only pull one matching platform by default.
When checking the size of image we match that behavior so that
we don't look for multiple platforms that might not exist on disk.
Signed-off-by: Darren Shepherd [email protected]
(cherry picked from commit 1161409)
Signed-off-by: Wei Fu [email protected]
cherry-pick: #3484