Skip to content

Add UnpackOpts to RemoteContext#3505

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:remoteopts-unpack
Aug 8, 2019
Merged

Add UnpackOpts to RemoteContext#3505
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:remoteopts-unpack

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 8, 2019

Codecov Report

Merging #3505 into master will decrease coverage by 3.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3505      +/-   ##
==========================================
- Coverage   48.04%   44.26%   -3.78%     
==========================================
  Files         113      124      +11     
  Lines       10928    13675    +2747     
==========================================
+ Hits         5250     6053     +803     
- Misses       4745     6687    +1942     
- Partials      933      935       +2
Flag Coverage Δ
#linux 48.04% <ø> (ø) ⬆️
#windows 39.74% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 47.9% <0%> (-8.6%) ⬇️
cio/io.go 46.47% <0%> (-8.53%) ⬇️
pkg/encryption/keywrap/pkcs7/keywrapper_pkcs7.go 44.61% <0%> (-8.12%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
pkg/encryption/keywrap/jwe/keywrapper_jwe.go 52.77% <0%> (-5.56%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
pkg/encryption/encryption.go 50.69% <0%> (-5.35%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb13fc...fe3638e. Read the comment docs.

@stefanberger
Copy link
Copy Markdown
Contributor

makes things work for me

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit 23faecf into containerd:master Aug 8, 2019
@crosbymichael crosbymichael deleted the remoteopts-unpack branch August 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants