Skip to content

cast Rdev of Stat_t to uint64 for mips#3501

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
wanghuaiqing2010:master
Aug 8, 2019
Merged

cast Rdev of Stat_t to uint64 for mips#3501
crosbymichael merged 1 commit intocontainerd:masterfrom
wanghuaiqing2010:master

Conversation

@wanghuaiqing2010
Copy link
Copy Markdown

Signed-off-by: wanghuaiqing [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 7, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 7, 2019

Build succeeded.

@wanghuaiqing2010 wanghuaiqing2010 changed the title cast Dev and Rdev of Stat_t to uint64 for mips cast Rdev of Stat_t to uint64 for mips Aug 7, 2019
@wanghuaiqing2010
Copy link
Copy Markdown
Author

wanghuaiqing2010 commented Aug 7, 2019

I only made a few changes, but the Travis CI build failed.
Could you help me?

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Aug 7, 2019

@wanghuaiqing2010 you can git commit -s --amend --no-edit and repush again to re-trigger it . Thanks

@wanghuaiqing2010
Copy link
Copy Markdown
Author

@fuweid Thanks for your help.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 7, 2019

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 7, 2019

Thanks for the PR! Since this is your first in containerd, can you re-push with your full name in the signed-off-by so we can add you properly to the mailmap (https://github.com/containerd/containerd/blob/master/.mailmap) file? Thanks!

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@wanghuaiqing2010
Copy link
Copy Markdown
Author

@estesp Yes, wanghuaiqing is my full name.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 8, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3501 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3501   +/-   ##
=======================================
  Coverage   44.26%   44.26%           
=======================================
  Files         124      124           
  Lines       13675    13675           
=======================================
  Hits         6053     6053           
  Misses       6687     6687           
  Partials      935      935
Flag Coverage Δ
#linux 48.04% <0%> (ø) ⬆️
#windows 39.74% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts_linux.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5222236...d8322e3. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 1eb13fc into containerd:master Aug 8, 2019
@crosbymichael crosbymichael added this to the 1.3 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants