Skip to content

Update 1.3 beta release notes#3499

Merged
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:update-beta-release-notes
Aug 7, 2019
Merged

Update 1.3 beta release notes#3499
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:update-beta-release-notes

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Aug 6, 2019

Add CRI changes and update the rest of the notes to look as good as those. Update mailmap to handle duplicate entries.

See test generation of notes here https://gist.github.com/dmcgowan/faa870c4a0890e739fd1aaf0cfd76eff

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 6, 2019

Build succeeded.

Comment thread releases/v1.3.0-beta.toml Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmcgowan - Can we make this [hcsshim](https://github.com/Microsoft/hcsshim/cmd/containerd-shim-runhcs-v1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yep. Thats what I get for not checking the link I type :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but can you add a README file under the cmd there which explains how to use it with containerd then?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 6, 2019

Codecov Report

Merging #3499 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3499   +/-   ##
=======================================
  Coverage   44.27%   44.27%           
=======================================
  Files         124      124           
  Lines       13672    13672           
=======================================
  Hits         6053     6053           
  Misses       6684     6684           
  Partials      935      935
Flag Coverage Δ
#linux 48.05% <ø> (+0.01%) ⬆️
#windows 39.75% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d934a...635ccc0. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the update-beta-release-notes branch from 772a1f5 to 635ccc0 Compare August 6, 2019 20:31
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 6, 2019

Build succeeded.

@estesp estesp merged commit 2ff1ef4 into containerd:master Aug 7, 2019
@dmcgowan dmcgowan deleted the update-beta-release-notes branch August 7, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants