Skip to content

Limit default matrix to runc v2 runtime#3498

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:limit-ppc64le
Aug 6, 2019
Merged

Limit default matrix to runc v2 runtime#3498
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:limit-ppc64le

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Aug 6, 2019

Explicitly add runc v1 runtime test on Linux.

Attempt at fixing slowness and flakiness from ppc64le before completely disabling.

Explicitly add runc v1 runtime test on Linux

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 6, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3498 into master will increase coverage by 4.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3498      +/-   ##
==========================================
+ Coverage   39.75%   44.27%   +4.51%     
==========================================
  Files          86      124      +38     
  Lines       11497    13672    +2175     
==========================================
+ Hits         4571     6053    +1482     
- Misses       6272     6684     +412     
- Partials      654      935     +281
Flag Coverage Δ
#linux 48.05% <ø> (?)
#windows 39.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
snapshots/devmapper/snapshotter.go 66.39% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
runtime/v2/shim/shim_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
oci/spec_opts_linux.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225cc7d...7792c23. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 13c6dcd into containerd:master Aug 6, 2019
@dmcgowan dmcgowan deleted the limit-ppc64le branch August 6, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants