pusher.go: error message typo correction#3497
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Aug 7, 2019
Merged
Conversation
|
Build succeeded.
|
TomSweeneyRedHat
left a comment
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM
Thanks @ethan-daocloud !
AkihiroSuda
reviewed
Aug 6, 2019
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM but please sign with full name
Member
|
Can you rebase on master when you update your signoff? Thanks! |
Signed-off-by: Guangming Wang <[email protected]>
Author
|
@AkihiroSuda |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3497 +/- ##
=======================================
Coverage 44.27% 44.27%
=======================================
Files 124 124
Lines 13672 13672
=======================================
Hits 6053 6053
Misses 6684 6684
Partials 935 935
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guangming Wang [email protected]