v2: Close ttrpc connection when Delete()#3496
Merged
fuweid merged 1 commit intocontainerd:masterfrom Aug 6, 2019
Merged
Conversation
|
Build succeeded.
|
darfux
force-pushed
the
v2_close_ttrpc_when_delete
branch
from
2c59006 to
282e1a1
Compare
|
Build succeeded.
|
darfux
force-pushed
the
v2_close_ttrpc_when_delete
branch
from
282e1a1 to
0edfe48
Compare
|
Build succeeded.
|
darfux
force-pushed
the
v2_close_ttrpc_when_delete
branch
from
0edfe48 to
0c7950c
Compare
|
Build succeeded.
|
This avoids potential socket leak when the connected v2 shim of runtime serving multiple containers. Signed-off-by: Li Yuxuan <[email protected]>
darfux
force-pushed
the
v2_close_ttrpc_when_delete
branch
from
0c7950c to
08483d1
Compare
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids potential socket leak when the connected v2 shim of runtime
serving multiple containers.
Signed-off-by: Li Yuxuan [email protected]