Completely remove Windows v2 in-tree shim#3494
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Aug 6, 2019
Merged
Conversation
Contributor
Author
|
@dmcgowan - We will want this for 1.3-beta |
Contributor
Author
|
Sorry I mean 1.3.0-beta1 |
Member
|
Sounds good, how about |
|
Build succeeded.
|
Signed-off-by: Justin Terry (VM) <[email protected]>
Contributor
Author
Good catch. I thought we needed it but we only needed the Updated |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
+ Coverage 44.25% 44.27% +0.01%
==========================================
Files 124 124
Lines 13829 13672 -157
==========================================
- Hits 6120 6053 -67
+ Misses 6767 6684 -83
+ Partials 942 935 -7
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Terry (VM) [email protected]