Skip to content

Fix travis matrix#3493

Merged
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-travis-matrix
Aug 6, 2019
Merged

Fix travis matrix#3493
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-travis-matrix

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Aug 5, 2019

Move matrix components next to each other for clarity.
Explicitly add special matrix combinations (Darwin and Linux V1 runtime)

This addresses the matrix part of #3491

Move matrix components next to each other for clarity.
Explicitly add special matrix combinations.

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 5, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3493 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3493   +/-   ##
=======================================
  Coverage   44.25%   44.25%           
=======================================
  Files         124      124           
  Lines       13829    13829           
=======================================
  Hits         6120     6120           
  Misses       6767     6767           
  Partials      942      942
Flag Coverage Δ
#linux 48.05% <ø> (ø) ⬆️
#windows 39.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e56c5...2398421. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit dce8541 into containerd:master Aug 6, 2019
@dmcgowan dmcgowan deleted the fix-travis-matrix branch September 10, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants