Skip to content

Mark devices with invalid state as faulty#3489

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:faulty
Aug 5, 2019
Merged

Mark devices with invalid state as faulty#3489
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:faulty

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Aug 5, 2019

This PR addresses comment #3470 (comment) from my previous PR.
In case of hard reset or crash, the snapshotter will mark devices as Faulty after restart if they're in incomplete (intermediate) state.

cc @renzhengeek @samuelkarp

ref #3436

Signed-off-by: Maksym Pavlenko [email protected]

Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 5, 2019

Build succeeded.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 29e56c5 into containerd:master Aug 5, 2019
@mxpv mxpv deleted the faulty branch August 5, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants