Fix containerd on windows.#3485
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 5, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
=======================================
Coverage 44.18% 44.18%
=======================================
Files 124 124
Lines 13751 13751
=======================================
Hits 6076 6076
Misses 6744 6744
Partials 931 931
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Aug 4, 2019
mxpv
approved these changes
Aug 4, 2019
Contributor
|
@Random-Liu - Thanks! Michael recently removed this and I forgot to tell him to do this part. |
fuweid
reviewed
Aug 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Containerd on windows doesn't work now, because task service can't start because of the missing
io.containerd.runtime.v1./cc @jterry75
Signed-off-by: Lantao Liu [email protected]