Limit multiple platform manifests to one for size check#3484
Limit multiple platform manifests to one for size check#3484fuweid merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
|
@ibuildthecloud thanks for the fix. But we still need sign-it-off with your real name :P |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think maybe we need to distinguish here between image Size and Usage. Perhaps usage is what is really concerned about here and we should just be skipping any resource which cannot be found locally. If that is the case, if we just have a Size function which can determine the size of an image given a platform, that would error out if it cannot find the manifests, however I am not sure how useful that function is for anything except introspection. Likewise a usage function may want to account for snapshot usage as well as blob usage.
|
Can you please rebase (force it to use the fixed test config) and sign, I think this change is fine for now. I think a better solution would be more involved, but this change represents client expectations for getting the size from a pulled image. |
client.Pull will only pull one matching platform by default. When checking the size of image we match that behavior so that we don't look for multiple platforms that might not exist on disk. Signed-off-by: Darren Shepherd <[email protected]>
|
Build succeeded.
|
|
LGTM, ignore Travis' red 'x' for now, it is from canceling ppc64le job |
4 participants
client.Pull will only pull one matching platform by default.
When checking the size of image we match that behavior so that
we don't look for multiple platforms that might not exist on disk.
Fixes #3387 and #2991