ECI: gpg: Pass the passphrase to the gpg2 tool using a pipe#3475
Merged
estesp merged 2 commits intocontainerd:masterfrom Aug 2, 2019
Merged
ECI: gpg: Pass the passphrase to the gpg2 tool using a pipe#3475estesp merged 2 commits intocontainerd:masterfrom
estesp merged 2 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
stefanberger
force-pushed
the
gpg2-passphrase-via-file
branch
from
0f8f9ae to
80cad67
Compare
Rather than passing the passphrase via command line write it into a temp. file and pass the name of the file using passphrase-file option. Signed-off-by: Stefan Berger <[email protected]>
Use a Pipe() rather than a file to pass the passphrase to the command line tool. Pass the file descriptor to read the passphrase from as fd '3'. Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
gpg2-passphrase-via-file
branch
from
80cad67 to
5cf7991
Compare
Contributor
Author
|
Ah, first file descriptor needs to be passed as '3' in golang. Now doing this via pipe() works. |
|
Build succeeded.
|
stefanberger
changed the title
stefanberger
changed the title
dmcgowan
approved these changes
Aug 1, 2019
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
I still have some reservations on the use of the passphrase, but that discussion is separate from whether this PR is better than what is there before. Let's get this merged in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than passing the passphrase via command line write it into
a temp. file and pass the name of the file using passphrase-file option.
Signed-off-by: Stefan Berger [email protected]