Add UUID and server info to introspection#3474
Conversation
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=======================================
Coverage 44.24% 44.24%
=======================================
Files 124 124
Lines 13732 13732
=======================================
Hits 6076 6076
Misses 6725 6725
Partials 931 931
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=======================================
Coverage 44.24% 44.24%
=======================================
Files 124 124
Lines 13732 13732
=======================================
Hits 6076 6076
Misses 6725 6725
Partials 931 931
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=======================================
Coverage 44.24% 44.24%
=======================================
Files 124 124
Lines 13732 13732
=======================================
Hits 6076 6076
Misses 6725 6725
Partials 931 931
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=======================================
Coverage 44.25% 44.25%
=======================================
Files 124 124
Lines 13829 13829
=======================================
Hits 6120 6120
Misses 6767 6767
Partials 942 942
Continue to review full report at Codecov.
|
|
LGTM |
|
cc @tonistiigi |
|
The uuid part sgtm . I don't understand the use case for the arch/os though. This is already in for runtime plugin for checking what platforms are supported. There it is also an array because multiple values might apply and uses type with a variant field that is required for arm(although missing osversion atm that is required for windows). |
|
ping @crosbymichael |
Closes containerd#1862 This adds a new rpc to the introspection service to provide server information with a generated UUID that is done on demand and the os and arch of the server. ctr output: ```bash > sudo ctr version Client: Version: v1.2.0-802-g57821695.m Revision: 5782169.m Server: Version: v1.2.0-802-g57821695.m Revision: 5782169.m UUID: 92e982a9-f13e-4a2c-9032-e69b27fed454 OS: linux ARCH: amd64 ``` Signed-off-by: Michael Crosby <[email protected]>
|
Resolved feedback |
|
Build succeeded.
|
8 participants
Closes #1862
This adds a new rpc to the introspection service to provide server
information with a generated UUID that is done on demand and the os and
arch of the server.
ctr output:
> sudo ctr version Client: Version: v1.2.0-802-g57821695.m Revision: 578216950de9c1c188708369e2a31ac6c494dfee.m Server: Version: v1.2.0-802-g57821695.m Revision: 578216950de9c1c188708369e2a31ac6c494dfee.m UUID: 92e982a9-f13e-4a2c-9032-e69b27fed454 OS: linux ARCH: amd64Signed-off-by: Michael Crosby [email protected]