Skip to content

Add note about pb.txt files#3469

Merged
jterry75 merged 1 commit intocontainerd:masterfrom
crosbymichael:pb.txt
Jul 30, 2019
Merged

Add note about pb.txt files#3469
jterry75 merged 1 commit intocontainerd:masterfrom
crosbymichael:pb.txt

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #3163

Signed-off-by: Michael Crosby [email protected]

Closes containerd#3163

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 30, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3469 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3469   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files         124      124           
  Lines       13732    13732           
=======================================
  Hits         6076     6076           
  Misses       6725     6725           
  Partials      931      931
Flag Coverage Δ
#linux 48.04% <ø> (ø) ⬆️
#windows 39.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4195136...5782169. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3469 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3469   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files         124      124           
  Lines       13732    13732           
=======================================
  Hits         6076     6076           
  Misses       6725     6725           
  Partials      931      931
Flag Coverage Δ
#linux 48.04% <ø> (ø) ⬆️
#windows 39.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4195136...5782169. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75 jterry75 merged commit e04f959 into containerd:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification on GRPC API and pb.txt format

4 participants