Skip to content

Call CloseIO when stdin closes in ctr#3462

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ctr-hang
Jul 26, 2019
Merged

Call CloseIO when stdin closes in ctr#3462
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ctr-hang

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Jul 26, 2019

Fixes #2439

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 26, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 26, 2019

Codecov Report

Merging #3462 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
- Coverage   44.22%   44.22%   -0.01%     
==========================================
  Files         124      124              
  Lines       13724    13724              
==========================================
- Hits         6070     6069       -1     
- Misses       6723     6724       +1     
  Partials      931      931
Flag Coverage Δ
#linux 48.01% <ø> (ø) ⬆️
#windows 39.88% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
runtime/v2/shim/shim_windows.go 42.85% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...f543f2f. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 26, 2019

Codecov Report

Merging #3462 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
- Coverage   44.22%   44.22%   -0.01%     
==========================================
  Files         124      124              
  Lines       13724    13724              
==========================================
- Hits         6070     6069       -1     
- Misses       6723     6724       +1     
  Partials      931      931
Flag Coverage Δ
#linux 48.01% <ø> (ø) ⬆️
#windows 39.88% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
runtime/v2/shim/shim_windows.go 42.85% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...f543f2f. Read the comment docs.

dmcgowan
dmcgowan approved these changes Jul 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Jul 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit eabb536 into containerd:master Jul 26, 2019
@estesp
Copy link
Copy Markdown
Member

estesp commented Jul 26, 2019

reported on 1.1.x; marked for cherry pick unless there is some reason it can't be taken back to 1.1.x

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jul 26, 2019

1.1.x is fine. The branch is out of support but still temporarily open for last 1.1.8 release.

@estesp estesp mentioned this pull request Aug 5, 2019
Merged
@tianon tianon mentioned this pull request Sep 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Execing a process blocks when stdin has content (most of the time)

4 participants

@crosbymichael @codecov-io @estesp @dmcgowan