Skip to content

Fast path getting pid from task#3461

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:pid-fastpath
Jul 26, 2019
Merged

Fast path getting pid from task#3461
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:pid-fastpath

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 26, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3461 into master will increase coverage by 3.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3461      +/-   ##
==========================================
+ Coverage   44.22%   48.01%   +3.78%     
==========================================
  Files         124      113      -11     
  Lines       13724    10831    -2893     
==========================================
- Hits         6070     5200     -870     
+ Misses       6723     4709    -2014     
+ Partials      931      922       -9
Flag Coverage Δ
#linux 48.01% <ø> (ø) ⬆️
#windows ?
Impacted Files Coverage Δ
remotes/docker/fetcher.go 42.5% <0%> (-7.5%) ⬇️
remotes/docker/auth.go 63.82% <0%> (-3.97%) ⬇️
remotes/docker/status.go 21.42% <0%> (-3.58%) ⬇️
platforms/cpuinfo.go 3.77% <0%> (-0.85%) ⬇️
log/context.go 36.84% <0%> (-0.66%) ⬇️
remotes/docker/handler.go 22.38% <0%> (-0.09%) ⬇️
errdefs/grpc.go 77.46% <0%> (-0.04%) ⬇️
remotes/docker/pusher.go 0% <0%> (ø) ⬆️
content/local/locks.go 100% <0%> (ø) ⬆️
pkg/encryption/gpg.go 0% <0%> (ø) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...eb4b3e8. Read the comment docs.

Comment thread runtime/task.go
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e00ebfb into containerd:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants