Skip to content

Specify protocols in ctr encrypt recipients#3460

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
lumjjb:ctrrecipients
Aug 1, 2019
Merged

Specify protocols in ctr encrypt recipients#3460
dmcgowan merged 1 commit intocontainerd:masterfrom
lumjjb:ctrrecipients

Conversation

@lumjjb
Copy link
Copy Markdown
Contributor

@lumjjb lumjjb commented Jul 26, 2019

Second part to address #3443. Modified ctr images encrypt command --recipient option to add a protocol prefix. i.e. pgp:[email protected], jwe:/path/to/pubkey, pkcs7:/path/to/x509

Signed-off-by: Brandon Lum [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 26, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3460   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files         124      124           
  Lines       13724    13724           
=======================================
  Hits         6070     6070           
  Misses       6723     6723           
  Partials      931      931
Flag Coverage Δ
#linux 48.01% <ø> (ø) ⬆️
#windows 39.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...8cd480c. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit adad947 into containerd:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants