Create CryptoConfig constructors to replace dcparameters#3452
Merged
estesp merged 2 commits intocontainerd:masterfrom Jul 25, 2019
lumjjb:keybundles
Merged
Create CryptoConfig constructors to replace dcparameters#3452estesp merged 2 commits intocontainerd:masterfrom lumjjb:keybundles
estesp merged 2 commits intocontainerd:masterfrom
lumjjb:keybundles
Conversation
Signed-off-by: Brandon Lum <[email protected]>
Signed-off-by: Brandon Lum <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3452 +/- ##
==========================================
+ Coverage 44.11% 44.22% +0.11%
==========================================
Files 124 124
Lines 13760 13724 -36
==========================================
Hits 6070 6070
+ Misses 6759 6723 -36
Partials 931 931
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3452 +/- ##
==========================================
+ Coverage 44.11% 44.22% +0.11%
==========================================
Files 124 124
Lines 13760 13724 -36
==========================================
Hits 6070 6070
+ Misses 6759 6723 -36
Partials 931 931
Continue to review full report at Codecov.
|
Member
|
Awesome improvement LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step to #3443, we've provided interfaces via the encryption library to create the necessary
CryptoConfigstructures for encryption/decryption without the need to know internals of the encryption scheme..We've implemented the following interfaces and updated
ctrusage to use it. In addition, there is no longer any use ofdcparametersin the codebase outside the encryption library - which uses its internals.We are thinking that when the OCI spec gets merged, an option is for the
pkg/encryptionlibrary to be under the OCI repo. So this would be the interface provided to create the configurations.