Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 46s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 38s (non-voting)

Codecov Report

Merging #3449 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3449   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files         124      124           
  Lines       13724    13724           
=======================================
  Hits         6070     6070           
  Misses       6723     6723           
  Partials      931      931

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...e3cc9c2. Read the comment docs.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 16s (non-voting)

After looking at this more, I think it would be better to move the errdefs.IsNotFound to https://github.com/containerd/containerd/blob/master/container_opts.go#L174

That way, we do not need to have the string check for "snapshot". Can you make this change?

After looking at this more, I think it would be better to move the errdefs.IsNotFound to https://github.com/containerd/containerd/blob/master/container_opts.go#L174

That way, we do not need to have the string check for "snapshot". Can you make this change?

so what you mean is that if the error type is IsNotFound in function WithSnapshotCleanup, we just ignore the error and return nil ?

@YLonely Yes. Exactly that

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 34s (non-voting)

LGTM

Thanks!