Skip to content

Call Update of snapshotter plugin#3447

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:update
Jul 29, 2019
Merged

Call Update of snapshotter plugin#3447
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:update

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Jul 24, 2019

Closes #3434

Signed-off-by: Maksym Pavlenko [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 24, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 24, 2019

Codecov Report

Merging #3447 into master will increase coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
+ Coverage   44.22%   44.24%   +0.01%     
==========================================
  Files         124      124              
  Lines       13724    13732       +8     
==========================================
+ Hits         6070     6076       +6     
- Misses       6723     6725       +2     
  Partials      931      931
Flag Coverage Δ
#linux 48.04% <60%> (+0.03%) ⬆️
#windows 39.86% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
metadata/snapshot.go 47.9% <37.5%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabb536...98ead46. Read the comment docs.

Comment thread metadata/snapshot.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 25, 2019

Build succeeded.

@crosbymichael crosbymichael requested a review from dmcgowan July 25, 2019 19:19
Comment thread metadata/snapshot.go Outdated
Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 26, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 172fe90 into containerd:master Jul 29, 2019
@mxpv mxpv deleted the update branch July 29, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why does containerd not use the Update interface of the snapshotter plugin?

4 participants