Add timeout to task state calls#3444
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 25, 2019
Merged
Conversation
estesp
reviewed
Jul 23, 2019
Fixes containerd#3440 This also returns the task that times out or has an error on the state call in an UNKNOWN status so that the user can manually kill and remove the task. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
state-timeout
branch
from
f957d07 to
101d4b7
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
=========================================
- Coverage 44.11% 44.1% -0.01%
=========================================
Files 124 124
Lines 13760 13760
=========================================
- Hits 6070 6069 -1
- Misses 6759 6760 +1
Partials 931 931
Continue to review full report at Codecov.
|
jterry75
reviewed
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3440
This also returns the task that times out or has an error on the state
call in an UNKNOWN status so that the user can manually kill and remove
the task.
Signed-off-by: Michael Crosby [email protected]