Update ctr to support deleting multiple tasks at a time#3441
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 25, 2019
YLonely:multiple-task-delete
Merged
Update ctr to support deleting multiple tasks at a time#3441estesp merged 1 commit intocontainerd:masterfrom YLonely:multiple-task-delete
estesp merged 1 commit intocontainerd:masterfrom
YLonely:multiple-task-delete
Conversation
|
Build succeeded.
|
Member
|
CI does not like your commit message: |
|
Build succeeded.
|
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3441 +/- ##
=======================================
Coverage 44.11% 44.11%
=======================================
Files 124 124
Lines 13760 13760
=======================================
Hits 6070 6070
Misses 6759 6759
Partials 931 931
Continue to review full report at Codecov.
|
|
Build succeeded.
|
estesp
reviewed
Jul 24, 2019
Member
There was a problem hiding this comment.
This can early return before attempting to delete all tasks; seems like you need a way to store (and report) non-zero exit codes if you are going to do multi-delete.
Signed-off-by: BoWen Yan <[email protected]>
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr include two things:
For the 2nd update now we can use "ctr task rm $(ctr task ls -q)" to quickly remove unused tasks.
The main body of the "exec-id" flag stays unchanged, which can only delete one exec at a time, the behavior of "exec-id" may need more discussion
Signed-off-by: BoWen Yan [email protected]