Skip to content

Remove windows v1 runtime#3439

Merged
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:rm-windows
Jul 24, 2019
Merged

Remove windows v1 runtime#3439
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:rm-windows

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #3094

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 22, 2019

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 22, 2019

Build succeeded.

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75
Copy link
Copy Markdown
Contributor

@crosbymichael - You will have to disable CI for now I think

@crosbymichael
Copy link
Copy Markdown
Member Author

Ok, I"ll keep working on this and get it into a good shape

@crosbymichael
Copy link
Copy Markdown
Member Author

@jterry75 is there any other way to get this running without disabling the tests?

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 23, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3439   +/-   ##
=======================================
  Coverage   44.11%   44.11%           
=======================================
  Files         124      124           
  Lines       13760    13760           
=======================================
  Hits         6070     6070           
  Misses       6759     6759           
  Partials      931      931
Flag Coverage Δ
#linux 47.87% <ø> (ø) ⬆️
#windows 39.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f776141...e097ab8. Read the comment docs.

@estesp
Copy link
Copy Markdown
Member

estesp commented Jul 23, 2019

What needs to happen to re-enable the integration tests on Windows CI? Is that something we would plan to have in place by 1.3?

@jterry75
Copy link
Copy Markdown
Contributor

I think to do that we have to start using the containerd-shim-runhcs-v1.exe from hcsshim. This is the only runtime that is actually supported moving forward. I think I am fine with disabling for now knowing that we will get this shim released

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although I do want a timeline for re-enabling some of this testing. Will we be able to get it before we cut 1.3 final (say by end of August)

@jterry75
Copy link
Copy Markdown
Contributor

@dmcgowan - Done deal.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a4e2ea5 into containerd:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully remove Windows v1 Runtime

5 participants