test: Check manifest.Platform before dereferencing#3438
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 22, 2019
Merged
test: Check manifest.Platform before dereferencing#3438estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
If the registry returns a manifest without platform info, the `manifest.Platform` will be `nil` and cause panic when dereferencing. Signed-off-by: Li Yuxuan <[email protected]>
darfux
force-pushed
the
test_check_manifest_platform_nil
branch
from
74957bc to
5e5ae23
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
=======================================
Coverage 44.32% 44.32%
=======================================
Files 123 123
Lines 13693 13693
=======================================
Hits 6070 6070
Misses 6692 6692
Partials 931 931
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the registry returns a manifest without platform info, the
manifest.Platformwill beniland cause panic when dereferencing. Such as:Signed-off-by: Li Yuxuan [email protected]