Fix bug in setting request body#3431
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 18, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3431 +/- ##
==========================================
- Coverage 44.28% 44.24% -0.04%
==========================================
Files 123 123
Lines 13665 13675 +10
==========================================
Hits 6051 6051
- Misses 6683 6693 +10
Partials 931 931
Continue to review full report at Codecov.
|
Member
|
AppVeyor did not run on the PR; seems GitHub is having degraded perf. issues with API/web. |
Go documentation says `Use of GetBody still requires setting Body`. This change ensures the body is always set in addition to GetBody. This fixes a bug where sometimes the body is nil. Signed-off-by: Derek McGowan <[email protected]>
Member
|
LGTM |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go documentation says
Use of GetBody still requires setting Body.This change ensures the body is always set in addition to GetBody. This fixes a bug where sometimes the body is nil.
Fixes #3427