Skip to content

[release/1.2] runtime/v1/linux: ignore ErrCgroupDeleted in Task.Start#3428

Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from
AkihiroSuda:fix-task-start-1.2
Jul 18, 2019
Merged

[release/1.2] runtime/v1/linux: ignore ErrCgroupDeleted in Task.Start#3428
crosbymichael merged 1 commit intocontainerd:release/1.2from
AkihiroSuda:fix-task-start-1.2

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Cherry-pick #3419

Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment)
Related: containerd#1598

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit fab016c)
Signed-off-by: Akihiro Suda <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3428 into release/1.2 will decrease coverage by 3.58%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3428      +/-   ##
===============================================
- Coverage        47.25%   43.66%   -3.59%     
===============================================
  Files               92      101       +9     
  Lines             8471    10816    +2345     
===============================================
+ Hits              4003     4723     +720     
- Misses            3738     5357    +1619     
- Partials           730      736       +6
Flag Coverage Δ
#linux 47.25% <ø> (ø) ⬆️
#windows 40.78% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
remotes/docker/resolver.go 59.2% <0%> (-5.09%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18100a3...227ebf3. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants