Skip to content

Makefile: allow custom base path to install#3422

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
fuweid:me-support-customize-install-path
Jul 17, 2019
Merged

Makefile: allow custom base path to install#3422
crosbymichael merged 1 commit intocontainerd:masterfrom
fuweid:me-support-customize-install-path

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Jul 17, 2019

for example, make DESTDIR=/usr install.

Signed-off-by: Wei Fu [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 17, 2019

Build succeeded.

for example, `make DESTDIR=/usr install`.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid force-pushed the me-support-customize-install-path branch from cde8c8a to b72673f Compare July 17, 2019 13:26
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 17, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3422   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         113      113           
  Lines       12563    12563           
=======================================
  Hits         5660     5660           
  Misses       6049     6049           
  Partials      854      854
Flag Coverage Δ
#linux 48.98% <ø> (ø) ⬆️
#windows 40.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129942c...b72673f. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit e237439 into containerd:master Jul 17, 2019
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid deleted the me-support-customize-install-path branch August 22, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants