[release/1.2] images: only fetch the best matched manifest info#3421
Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from Jul 17, 2019
Merged
Conversation
When client uses Pull action to pull image, it will limit the number of manifest as one. But Unpack action will call Manifest to traverse all the manifests including non-dowloaded one. If the platform has more than one manifest, the Pull with unpack action will fail. And also, there is no need to read non-best matched manifest. Therefore, the Manifest can do the sort earlier. Signed-off-by: Wei Fu <[email protected]>
fuweid
changed the title
Member
Author
|
fixes #3387 |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3421 +/- ##
============================================
Coverage 43.66% 43.66%
============================================
Files 101 101
Lines 10816 10816
============================================
Hits 4723 4723
Misses 5357 5357
Partials 736 736
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When client uses Pull action to pull image, it will limit the number of
manifest as one. But Unpack action will call Manifest to traverse all
the manifests including non-dowloaded one. If the platform has more than
one manifest, the Pull with unpack action will fail. And also, there is
no need to read non-best matched manifest. Therefore, the Manifest can
do the sort earlier.
Signed-off-by: Wei Fu [email protected]