Skip to content

Fix regression from #3403 with snapshot cmd#3420

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:sn-regression
Jul 16, 2019
Merged

Fix regression from #3403 with snapshot cmd#3420
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:sn-regression

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

The snapshot command calls the snapshotter service directly, therefore,
the name must be resolved.

Signed-off-by: Michael Crosby [email protected]

The snapshot command calls the snapshotter service directly, therefore,
the name must be resolved.

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 16, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 36e4c8e into containerd:master Jul 16, 2019
@crosbymichael crosbymichael deleted the sn-regression branch July 16, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants