errors: use errdefs errors in client and commands#3418
errors: use errdefs errors in client and commands#3418fuweid merged 1 commit intocontainerd:masterfrom
Conversation
There was a problem hiding this comment.
This could be ErrUnavailable.
There was a problem hiding this comment.
This could be ErrUnavailable.
There was a problem hiding this comment.
This could be ErrUnavailable.
There was a problem hiding this comment.
This could be ErrUnsupported.
There was a problem hiding this comment.
This could be ErrUnavailable.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
There was a problem hiding this comment.
This could be ErrInvalidArgument.
|
I also annotated each error with the correct wrapped error type. |
|
Build succeeded.
|
|
change is LGTM. but the CI is not happy with non-signing commit :) |
|
@fuweid I’ll apply the suggestions and then squash the commit |
stevvooe
force-pushed
the
backout-error-changes
branch
from
e9a208b to
6520c37
Compare
stevvooe
changed the title
|
Build succeeded.
|
stevvooe
force-pushed
the
backout-error-changes
branch
from
6520c37 to
27c9f43
Compare
This change moves from specific, global errors to the errdefs errors. This makes it easy to handle certain classes of errors while still adding context to the failure. Signed-off-by: Stephen Day <[email protected]>
stevvooe
force-pushed
the
backout-error-changes
branch
from
27c9f43 to
804ae89
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
- Coverage 44.28% 40.27% -4.01%
==========================================
Files 123 76 -47
Lines 13665 10496 -3169
==========================================
- Hits 6051 4227 -1824
+ Misses 6683 5685 -998
+ Partials 931 584 -347
Continue to review full report at Codecov.
|
4 participants
This change moves from specific, global errors to the errdefs errors. This makes it easy to handle certain classes of errors while still adding context to the failure.