Replace hard coded error messages #3416
Merged
estesp merged 4 commits intocontainerd:masterfrom Jul 15, 2019
Merged
Conversation
Signed-off-by: Fahed Dorgaa <[email protected]>
Signed-off-by: Fahed Dorgaa <[email protected]>
Signed-off-by: Fahed Dorgaa <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Member
Author
|
@fahedouch I carried your commits and updated the feedback left on the PR to move the specific errors into their packages. Thanks for the initial commits and they are still in this PR. |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3416 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 113 113
Lines 12563 12563
=======================================
Hits 5660 5660
Misses 6049 6049
Partials 854 854
Continue to review full report at Codecov.
|
Member
|
Nice job @crosbymichael I'll do the same for the rest of the packages |
Member
|
I don't see how this addresses the feedback. These error messages appear in a single place. It makes it way hard to debug when bad things happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry of #3409
Closes #3349