Add flat GC label for leases#3415
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 19, 2019
Merged
Conversation
dmcgowan
force-pushed
the
gc-flat-lease
branch
2 times, most recently
from
2469e76 to
ed7329d
Compare
Member
|
LGTM |
fuweid
reviewed
Jul 16, 2019
AkihiroSuda
reviewed
Jul 17, 2019
Member
There was a problem hiding this comment.
Can be another PR, but we should have a documentation about these labels
Member
Author
There was a problem hiding this comment.
I was thinking the same thing
Member
|
needs rebase |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3415 +/- ##
==========================================
+ Coverage 44.28% 49.06% +4.78%
==========================================
Files 123 102 -21
Lines 13665 9916 -3749
==========================================
- Hits 6051 4865 -1186
+ Misses 6683 4206 -2477
+ Partials 931 845 -86
Continue to review full report at Codecov.
|
Provide a flag which configures a lease to only hold reference to its given references and ignore label references during garbage collection rooted from the lease. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a flag which configures a lease to only hold reference to its given references and ignore label references during garbage collection rooted from the lease.
This covers a use case to enable using longer lived leases which need to treat the references it is holding as immutable. Since labels are mutable, holding onto an object may cause the number of objects being referenced to grow even when the lease is only intending on keeping the original object. For example, a lease wants to keep a manifest, but not the blobs referred to within the manifest. When another process pulls in those blobs that lease now additionally holds those blobs even if the original process removed its reference to the manifest.
Also added higher level lease tests to test this case and normal leases.
cc @tonistiigi