Skip to content

Small refactor due to CI linter changes#3414

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
estesp:refactor-forloop
Jul 15, 2019
Merged

Small refactor due to CI linter changes#3414
dmcgowan merged 1 commit intocontainerd:masterfrom
estesp:refactor-forloop

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Jul 15, 2019

Without the open variable in use, no reason to define it or use it as the
for loop control.

cc: @fuweid

Signed-off-by: Phil Estes [email protected]

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 15, 2019

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

The CI is greedy, it wants more cmd/ctr/commands/events/events.go:74:3: unreachable: unreachable code (govet)

@cpuguy83
Copy link
Copy Markdown
Member

"Don't feed the linters"

Without the open variable in use, no reason to define it or use it as the
for loop control.

Signed-off-by: Phil Estes <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 15, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         113      113           
  Lines       12563    12563           
=======================================
  Hits         5660     5660           
  Misses       6049     6049           
  Partials      854      854
Flag Coverage Δ
#linux 48.98% <ø> (ø) ⬆️
#windows 40.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e148b...82826df. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         113      113           
  Lines       12563    12563           
=======================================
  Hits         5660     5660           
  Misses       6049     6049           
  Partials      854      854
Flag Coverage Δ
#linux 48.98% <ø> (ø) ⬆️
#windows 40.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e148b...82826df. Read the comment docs.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 7d03fc6 into containerd:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants