Switch from gometalinter to golangci-lint#3411
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Jul 15, 2019
Merged
Switch from gometalinter to golangci-lint#3411crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael merged 2 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
mxpv
force-pushed
the
linter
branch
2 times, most recently
from
eeec3f1 to
cafbd05
Compare
|
Build succeeded.
|
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3411 +/- ##
==========================================
- Coverage 48.98% 40.27% -8.72%
==========================================
Files 102 76 -26
Lines 9903 10496 +593
==========================================
- Hits 4851 4227 -624
- Misses 4207 5685 +1478
+ Partials 845 584 -261
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Jul 15, 2019
fuweid
reviewed
Jul 15, 2019
| select { | ||
| case e = <-eventsCh: | ||
| case err, open = <-errCh: | ||
| case err = <-errCh: |
Member
There was a problem hiding this comment.
it seems that we can remove the open var here because open always is true
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3410
Closes #3060