fix: view snapshot is deleted before diff#3408
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 15, 2019
wangpeng168:master
Merged
fix: view snapshot is deleted before diff#3408estesp merged 1 commit intocontainerd:masterfrom wangpeng168:master
estesp merged 1 commit intocontainerd:masterfrom
wangpeng168:master
Conversation
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
- Coverage 48.98% 45.05% -3.94%
==========================================
Files 102 113 +11
Lines 9903 12563 +2660
==========================================
+ Hits 4851 5660 +809
- Misses 4207 6049 +1842
- Partials 845 854 +9
Continue to review full report at Codecov.
|
mxpv
requested changes
Jul 13, 2019
|
Build succeeded.
|
mxpv
approved these changes
Jul 14, 2019
Signed-off-by: Peng Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using devmapper snapshotter to execute the following command error:
ctr snapshots --snapshotter devmapper diff idA idB
Root cause: view snapshot is deleted before diff
Signed-off-by: Peng Wang [email protected]