Better default label handling#3403
Merged
estesp merged 4 commits intocontainerd:masterfrom Jul 11, 2019
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3403 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 113 113
Lines 12563 12563
=======================================
Hits 5660 5660
Misses 6049 6049
Partials 854 854
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3403 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 113 113
Lines 12563 12563
=======================================
Hits 5660 5660
Misses 6049 6049
Partials 854 854
Continue to review full report at Codecov.
|
fuweid
reviewed
Jul 11, 2019
|
Build succeeded.
|
|
Build succeeded.
|
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
Member
|
LGTM |
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
Jul 16, 2019
The snapshot command calls the snapshotter service directly, therefore, the name must be resolved. Signed-off-by: Michael Crosby <[email protected]>
dmcgowan
added a commit
that referenced
this pull request
Jul 16, 2019
Fix regression from #3403 with snapshot cmd
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
The snapshot command calls the snapshotter service directly, therefore, the name must be resolved. Signed-off-by: Michael Crosby <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd.io/defaults/snapshotterlabel inctrpull/push and othersctr ns lsandctr ns c ...)ref: #2285