Build succeeded.

• containerd-build-arm64 : FAILURE in 6m 53s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 14s (non-voting)

You need to merge your two commits together to pass CI; let us know if you need help doing that! Thanks.

The errdefs package is intended to have a smaller set of error definitions and match the set of error codes used by grpc. The expected way to use the errdefs package is to wrap one of these with a more meaningful message. This package is not the place to add these more specific errors, however they can be added to individual packages where they are used to reduce duplication within a single package.

hello,

@dmcgowan what you just said is not wrong :).

What do you think about adding file to each package where we can centralize errors fo this specific package @crosbymichael ?

I am fine adding a centralizing within a package. In some cases though the error itself does not need to be exported and the errors would be better off as errors.Wrap(errdefs.ErrInvalidArgument, "some message why it is wrong"), and if that message is duplicated that is fine.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 11s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 8m 34s (non-voting)

You have a merge commit (that's empty) that needs to be removed to make CI run cleanly.

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.