Bump go-winio and refactor Windows snapshotters#3385
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jul 2, 2019
ehotinger:ehotinger/refactor-winio
Merged
Bump go-winio and refactor Windows snapshotters#3385crosbymichael merged 1 commit intocontainerd:masterfrom ehotinger:ehotinger/refactor-winio
crosbymichael merged 1 commit intocontainerd:masterfrom
ehotinger:ehotinger/refactor-winio
Conversation
|
Build succeeded.
|
This also refactors the lcow and windows snapshotters to use go-winio's utility functions for checking the filesystem type. Signed-off-by: Eric Hotinger <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3385 +/- ##
=======================================
Coverage 45.05% 45.05%
=======================================
Files 113 113
Lines 12563 12563
=======================================
Hits 5660 5660
Misses 6049 6049
Partials 854 854
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the version of go-winio to the latest commit and refactors the lcow and windows snapshotters to use go-winio's utility functions for checking the filesystem type. This means other folks like myself can write more windows-based snapshotters without copy/pasting this code everywhere.
It seems there is one breaking change in the
EnableCallbackfunc in microsoft/go-winio@a2a7cd6#diff-affd4dec288883c3d72b7e20004dfae5 - hence the changes toetwCallback.This PR closes #3362
@kevpar / @jterry75 / @jhowardmsft PTAL.
Signed-off-by: Eric Hotinger [email protected]