Skip to content

Add cgroup delete opt for ns deletion#3383

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ns-delete
Jul 1, 2019
Merged

Add cgroup delete opt for ns deletion#3383
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ns-delete

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Closes #3305

This adds an opt and a --cgroup,-c flag to ctr namespaces rm to
remove the cgroup that is commonly created with runtimes.

Signed-off-by: Michael Crosby [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 1, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Closes containerd#3305

This adds an opt and a `--cgroup,-c` flag to `ctr namespaces rm` to
remove the cgroup that is commonly created with runtimes.

Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 1, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 6617def into containerd:master Jul 1, 2019
@crosbymichael crosbymichael deleted the ns-delete branch July 2, 2019 02:20
@rcgoodfellow
Copy link
Copy Markdown

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

namespace top level cgroup folders leaking

4 participants