Skip to content

Handle RequestTimeout and TooManyRequests#3382

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
knm3000:content_fetch_retry
Jul 1, 2019
Merged

Handle RequestTimeout and TooManyRequests#3382
crosbymichael merged 1 commit intocontainerd:masterfrom
knm3000:content_fetch_retry

Conversation

@knm3000
Copy link
Copy Markdown
Contributor

@knm3000 knm3000 commented Jul 1, 2019

Retry 5 times in case of StatusRequestTimeout StatusTooManyRequests
This fixes the issue #2680 "Make content fetch retry more robust"

Signed-off-by: Konstantin Maksimov [email protected]

Retry 5 times in case of StatusRequestTimeout StatusTooManyRequests
This fixes the issue containerd#2680 "Make content fetch retry more robust"

Signed-off-by: Konstantin Maksimov <[email protected]>
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
See nit..

Thanks for making this PR welcome aboard!

return copyRequest(req)
}

// TODO: Handle 50x errors accounting for attempt history
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this todo

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 1, 2019

Build succeeded.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit d1b766a into containerd:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants